Fix docker scripts incompatibilities with non-GPU and graphics - #44
Merged
Conversation
…eded Signed-off-by: Xavier Ruiz <xavier.ruiz@ekumenlabs.com>
JesusSilvaUtrera
approved these changes
Nov 7, 2025
JesusSilvaUtrera
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, tested locally to build and run the container and no issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR removes the GUI and GPU support when running docker. The GPU setup is incorrect but since we do not need to run any simulation or graphic tool, it's better to simplify and just remove the related flags and environment values.
Type
How to test
Steps to reproduce / test the changes:
docker.shand ensure it does not throw any error.join.shand ensure it does not throw any error.Checklist
git commit -s) or added Signed-off-by to existing commits.Related issues