Fix indexing issue when no product variant is found#34
Merged
PierreGauthier merged 1 commit intoElastic-Suite:2.2.xfrom Nov 21, 2025
Conversation
shochdoerfer
force-pushed
the
fix/skip_indexing_products_without_variants
branch
5 times, most recently
from
541360f to
1cc1742
Compare
PierreGauthier
requested changes
Nov 21, 2025
shochdoerfer
force-pushed
the
fix/skip_indexing_products_without_variants
branch
from
1cc1742 to
5ab69a0
Compare
shochdoerfer
force-pushed
the
fix/skip_indexing_products_without_variants
branch
from
5ab69a0 to
2249391
Compare
PierreGauthier
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just bumped into an issue in one of our dev setups. I tried to create a product with variants. When saving the parent product before variants have been created, the Gally sync fails because $variant is false in the ProductIndexer.