[Indexer] Fix product suppression propagation - #48
Open
PierreGauthier wants to merge 1 commit into
Open
Conversation
PierreGauthier
commented
Jul 13, 2026
PierreGauthier
commented
Contributor
| Q | A |
|---|---|
| Branch? | master for features / current stable version branch for bug fixes |
| Tickets | #... |
| License | OSL-3.0 |
There was a problem hiding this comment.
Pull request overview
This PR aims to improve product “suppression” propagation by ensuring product deletions (and variant deletions) are reflected in the Gally index, and adjusts the product index sidebar rendering when Gally is disabled.
Changes:
- Capture product IDs pre-delete and delete corresponding documents from the index on post-delete.
- Add a generic
remove()bulk-deletion capability toAbstractIndexer. - Render a taxonomy/categories sidebar block when Gally is disabled and a
slugrequest attribute is present.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Resources/views/shop/product/index/content/body/sidebar/filters.html.twig | Adds a fallback taxonomy/categories render when Gally is disabled. |
| src/Indexer/Subscriber/ProductSubscriber.php | Adds product pre/post delete handling and variant post_delete reindexing. |
| src/Indexer/AbstractIndexer.php | Refactors localized-catalog iteration and introduces remove() for bulk deletions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+32
to
+33
| {% elseif app.request.attributes.has('slug') %} | ||
| {{ component('sylius_shop:product:show:taxonomy', {template: '@GallySyliusPlugin/shop/product/_shared/categories.html.twig'}) }} |
| @@ -31,8 +34,11 @@ public static function getSubscribedEvents() | |||
| return [ | |||
PierreGauthier
force-pushed
the
fix-productDelete
branch
from
July 13, 2026 14:10
fc7ce6b to
81344ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.