Add extension points for custom pricing/data and structure sync - #56
Open
PierreGauthier wants to merge 3 commits into
Open
Add extension points for custom pricing/data and structure sync#56PierreGauthier wants to merge 3 commits into
PierreGauthier wants to merge 3 commits into
Conversation
Adds a ProductDocumentsIndexEvent (indexation) and a SearchRequestContextEvent (search request, price_group_id) so a project can plug custom data/pricing logic without decorating the plugin. Also lets several dataproviders contribute to the same structure sync entity (catalog/sourceField/ sourceFieldOption), splitting the built-in attribute/option providers and subscribers accordingly as a first real usage of that mechanism. Refs #33, refs #1391443
Add the missing plugin file header to the two new Event classes, and align a phpdoc block per cs-fixer's own diff. ProductAttributeSourceFieldProvider had its own metadataCache instead of reusing AbstractSourceFieldProvider's, unlike the original SourceFieldProvider which cached Metadata instances in one place for both attributes and static fields. Expose it as getMetadata() on the abstract class instead.
The product/category slug fields aren't tied to attributes or options, they don't belong in ProductAttributeSourceFieldProvider either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.