Symfony 8 compatibility: convert XML DI config to PHP - #57
Open
PierreGauthier wants to merge 1 commit into
Open
Conversation
Symfony's DependencyInjection XML config format is deprecated since 7.4 and no longer supported in 8.0. Converts the plugin's 8 XML service files to PHP (ContainerConfigurator) one-to-one, and swaps XmlFileLoader for PhpFileLoader in GallySyliusExtension. Also bumps composer.json's stale extra.symfony.require and dev-dependency constraints to allow ^8.0. The Doctrine ORM XML mapping file is untouched, unrelated format. Fixes #55
PierreGauthier
force-pushed
the
fix-gh55-symfony8-xml-config
branch
from
August 12, 2026 12:55
6776619 to
71e4850
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #55. Symfony's DependencyInjection XML config format is deprecated since 7.4 ("Deprecate XML configuration format, use YAML or PHP instead") and no longer supported in 8.0, so the connector could not boot on Symfony 8.
services.xml+ 7 imported files) to PHP (ContainerConfigurator), one-to-one: same services, arguments, tags,parent/abstract,decorates, tagged iterators, factory service, parameters.GallySyliusExtension::load()now usesPhpFileLoaderinstead ofXmlFileLoader.GallyConfiguration.orm.xml) is untouched, unrelated format, not affected by this deprecation.extra.symfony.require(^5.4 || ^6.0→^6.4 || ^7.4 || ^8.0) and the dev dependencies pinned below^8.0(symfony/browser-kit,debug-bundle,dotenv,intl,web-profiler-bundle), as flagged in the issue.Test plan
vendor/bin/phpstan analysecleanphp -lon every converted filetests/Application, which isn't provisioned in this environment):bin/console cache:clearcompiles the container without errordebug:containerspot checks confirm exact parity with the previous XML for the trickiest constructs:ProductIndexer(parent/abstractargument inheritance),Grid\DataProvider(decorates),Command\StructureSync(tagged_iteratorwithindex-by)