feat(codex): configure native agents and hooks setup#1
Merged
Conversation
Add Codex-native skill test suite
…ents [codex] add native Codex subagent roles and hermetic Claude tests
…-hook fix: make Codex SessionStart hook targeting explicit
# Conflicts: # hooks/session-start
…-hook fix: support Codex SessionStart hooks on Windows
…nsion [codex] expand native workflow roles and harden role tests
…rifying-loop fix: keep brainstorming clarifying loop open-ended
…rifying-loop fix: enhance repo_checkout_fingerprint to include file mode in output
- Deleted `test-helpers.sh`, which contained helper functions for Codex skill tests. - Removed `test-model-config.sh`, which tested the Codex test environment configuration. - Eliminated `test-native-agent-catalog.sh`, which verified the native Superpowers Codex role catalog. - Removed `test-subagent-driven-development-integration.sh`, which integrated subagent-driven development workflows. - Deleted `test-subagent-driven-development.sh`, which tested the subagent-driven-development skill. - Removed `test-using-superpowers-bootstrap.sh`, which tested the using-superpowers bootstrap via SessionStart hook.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
This PR updates our fork with the Codex/Superpowers integration work from the local fork state and adds the missing setup path for Codex hooks and native agents.
Specific failure mode addressed in this session: Codex could discover Superpowers skills and agents only after manual setup, but there was no single script that configured skills, copied native
superpowers_*agents, enabledcodex_hooks, installed a safeSessionStarthook, and added the strict Superpowers Codex block toAGENTS.md.Note: this PR targets our own fork (
Electivus/superpowers). It includes earlier local Codex fork history becauseElectivus/mainwas still at the backup/original baseline when this branch was pushed.What does this PR change?
.codex/setup.shinstaller for skills, agents, hooks, config flags, and strict-modeAGENTS.mdsetup.Is this change appropriate for the core library?
For our fork, yes: these are general Codex integration and setup improvements, not project/domain-specific application logic.
For upstream core submission, this would need to be split and evaluated against upstream's stricter PR criteria, especially because the branch includes earlier fork history plus skill wording changes.
What alternatives did you consider?
AGENTS.mdseparately.~/.codex/hooks.json.hooks.jsonwholesale: rejected because it can delete third-party hooks; the setup script now removes only Superpowers hook entries and preserves unrelated hooks, including hooks in the same group.Does this PR contain multiple unrelated changes?
It contains related Codex integration changes, plus prior local fork history needed to bring
Electivus/mainup to the current local fork state. If this were proposed upstream, it should be split before submission.Existing PRs
obra/superpowersdocs: add optional Codex SessionStart hook setup obra/superpowers#1018, feat: lifecycle event hooks for external plugin authors obra/superpowers#1461, codex: installer can update AGENTS.md (markers; --no-agents) obra/superpowers#411, Add Codex-native skill test suite and enhance reviewer roles obra/superpowers#1083; none found inElectivus/superpowersRelevant prior art reviewed:
obra/superpowersdocs: add optional Codex SessionStart hook setup obra/superpowers#1018 documents optional CodexSessionStartsetup.obra/superpowersfeat: lifecycle event hooks for external plugin authors obra/superpowers#1461 adds lifecycle events for plugin authors, a separate hook surface from Codex lifecycle hooks.obra/superpowerscodex: installer can update AGENTS.md (markers; --no-agents) obra/superpowers#411 was a closed installer/AGENTS.mdupdate idea.obra/superpowersAdd Codex-native skill test suite and enhance reviewer roles obra/superpowers#1083 was a broad closed Codex-native test/role PR.Environment tested
New harness support (required if this PR adds a new harness)
N/A. This does not add a new harness; it extends the existing Codex integration with native agents, setup automation, and lifecycle hook support.
Clean-session transcript for "Let's make a react todo list"
N/A for this fork PR. No new harness was added. The Codex
SessionStarthook contract was validated by parsing the hook JSON output and assertinghookSpecificOutput.additionalContextcontains the currentusing-superpowersbootstrap.Evaluation
AGENTS.mdsteps and hooks were not included in plugin sync..codex/setup.shconfigures skills, copies native agents, enablescodex_hooksandmulti_agent, safely merges aSessionStarthook, installs the strict-mode block idempotently, and tests cover the key contracts.Rigor
superpowers:writing-skillsand completed adversarial pressure testing (paste results below)Adversarial/local checks performed:
.codex/setup.sh.[[array_table]]boundaries, avoidingresumeduplicate injection, safe uninstall docs, preserving third-party hooks in the same group, setup idempotency, and parsing Codex hook output as JSON.Fresh verification after final commit:
All listed commands exited 0 in this session.
Human review
The human partner explicitly requested opening this PR for our own fork after the local review/verification flow.