Skip to content

Conversation

@RCasatta
Copy link
Collaborator

@RCasatta RCasatta commented Oct 2, 2024

Fix errors with unprintable ascii chars like 656c74722874706b7561667465726c6f6132196f72616561667465726c6f72616561667465726c6f725f69693229 for roundtrip_descriptor

Note in 0196695 I replaced the custom impl with usptream fn for coherence, but the removed impl seems better than upstream (just checking the byte range seems equivalent)

@RCasatta RCasatta force-pushed the check_input_charset branch from c3b8654 to 03650dd Compare October 2, 2024 10:14
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 03650dd successfully ran local tests

@RCasatta RCasatta merged commit afb5f48 into ElementsProject:master Oct 2, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants