Skip to content

Descriptor: Add support for confidential descriptors #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
May 27, 2025
Merged

Descriptor: Add support for confidential descriptors #493

merged 19 commits into from
May 27, 2025

Conversation

@jgriffiths
Copy link
Contributor

@jgriffiths jgriffiths commented May 18, 2025 •
edited
Loading

  • Support el prefixes for descriptor builtins, and mark the descriptor as elements if used.
  • Support the top-level ct() confidential descriptor builtin.
  • Support slip77 and ELIP-150 blinding keys inside ct() descriptors.
  • Support fetching blinding keys from ct() descriptors.
  • Support confidential address generation from confidential descriptors.
  • Expose calls for pubkey and elip-150 tweaking.
  • Tests for the above.

jgriffiths added 17 commits May 12, 2025 23:00
@jgriffiths
descriptor: use the context and not node to determine elements-ness
1d8e0dc 
There is no need to use the node flags since the entire descriptor is
either Elements or not.
@jgriffiths
descriptor: use a named key for repeated key xpub
7075dce 
This key is reused in the ELIP-150 tests so give it a short name to make
the test easier to read.
@jgriffiths
descriptor: add support for elements el-prefixed descriptor builtins
00cc54b 
These are not documented anywhere and are only implemented in
rust-miniscript, which renames descriptor builtins to be prefixed
with "el" - making them incompatible with any descriptor currently
supported by Elements core.

However the test vectors from ELIP-0150 include elsh(wpkh()) expressions
in addition to elwpkh() expressions, which seems to indicate that mixing
prefixed and non-prefixed builtins should be accepted.

This implementation therefore allows mixing prefixed and non-prefixed
builtins, with the descriptor being marked as Elements if either a
prefixed builtin is given, or if the descriptor is explicitly parsed as
Elements via WALLY_MINISCRIPT_AS_ELEMENTS.
@jgriffiths
descriptor: add support for parsing ct descriptors with slip77 blindi…
beaca14 
…ng keys
@jgriffiths
elements: add asset_blinding_key_to_ec_public_key
ca056f8 
Allows callers to avoid doing the private-to-public key
conversion themselves.
@jgriffiths
descriptor: add support for generating elements slip77 confidential a…
6b2ba68 
…ddresses

Add the slip77 test cases from ELIP-0150.
@jgriffiths
build: fix job error reported on clean valgrind runs
0941e3f
@jgriffiths
txio: expose tagged hash helpers for internal use
f2a3fd1
@jgriffiths
crypto: add ec_public_key_tweak to tweak standard pubkeys
3ae219c 
Confidential descriptors require tweaking - wrap it to reduce
internal code duplication.
@jgriffiths
bip32: Simplify code by using ec_public_key_tweak internally
7c18c96
@jgriffiths
descriptor: support elip150 key expressions for ct() blinding keys
5df197f
@jgriffiths
descriptor: standardize generation handling of the length written
6a5d040 
generate_ functions behave like the standard wally API calls, while
generate_inplace_ functions read and possibly adjust the written
parameter because they modify already generated output.

Make this handling more explicit and consistent, and add a check to
avoid a scan-build false positive triggered by the new ct() code.
@jgriffiths
descriptor: extend tests to completely cover short buffer inputs
a170f50
@jgriffiths
descriptor: explicitly disallow wrappers on ct() and blinding keys
6ca519c
@jgriffiths
descriptor: allow hex private keys for ct() blinding keys
1c3c74b
@jgriffiths
descriptor: add tests for the number of keys in a descriptor
e67740b 
In particular, ensure that ct() blinding keys are not returned as
regular keys.
@jgriffiths
js: migrate ubuntu wasm build to 22.04 LTS
823f21c 
20.04 is EOL and no longer supported by github for building.
@jgriffiths jgriffiths force-pushed the elements_descriptor branch from a821abb to 823f21c Compare May 18, 2025 23:09
@jgriffiths jgriffiths force-pushed the elements_descriptor branch from 2658df1 to 45a7bed Compare May 20, 2025 06:19
@jgriffiths jgriffiths merged commit 45a7bed into master May 27, 2025
5 checks passed
@jgriffiths jgriffiths deleted the elements_descriptor branch May 27, 2025 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jgriffiths