Skip to content

address_to_scriptpubkey: correctly handle WALLY_NETWORK_BITCOIN_REGTEST #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025
Merged

address_to_scriptpubkey: correctly handle WALLY_NETWORK_BITCOIN_REGTEST #494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/address.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,8 @@ int wally_address_to_scriptpubkey(const char *addr, uint32_t network, unsigned c
version = decoded[0];
if (network_from_addr_version(version, &addr_network) != WALLY_OK)
return WALLY_EINVAL;
if (network == WALLY_NETWORK_BITCOIN_REGTEST)
network = WALLY_NETWORK_BITCOIN_TESTNET; /* regtest uses testnet prefix */
if (network != addr_network)
return WALLY_EINVAL;

Expand Down
2 changes: 2 additions & 0 deletions src/test/test_address.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

NETWORK_BITCOIN_MAINNET = 0x01
NETWORK_BITCOIN_TESTNET = 0x02
NETWORK_BITCOIN_REGTEST = 0xff
NETWORK_LIQUID_MAINNET = 0x03
NETWORK_LIQUID_REGTEST = 0x04
NETWORK_LIQUID_TESTNET = 0x05
Expand Down Expand Up @@ -96,6 +97,7 @@ def get_test_key(self, vec, path):
def test_address_vectors(self):
self.do_test_vector(vec, 'm/0H/1', NETWORK_BITCOIN_MAINNET)
self.do_test_vector(vec, 'm/1H/1', NETWORK_BITCOIN_TESTNET) # Testnet
self.do_test_vector(vec, 'm/1H/1', NETWORK_BITCOIN_REGTEST) # Testnet

def do_test_vector(self, vec, path, network):
key = self.get_test_key(vec, path)
Expand Down