Mbed sha256 #498
Merged
Mbed sha256 #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rearrange the code slightly to match the sha256 impl.
|
utack 1117e5b |
For example, mbedtls hardware hashing requires (at least) semaphore initialization/aquisition performed by sha256_init() to be done before the context is considered valid. Openssl with HW hashers is likely the same for at least some configs. so, for non-standard setups like these, avoid caching the initial bip340 tagged hash context. Many thanks to github users @advorzhak and @hazrulnizam for helping to reproduce the issue!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanups for the ccan sha code and a fix for tx_io hashing for non-default sha256 implementations (affecting taproot txs with more than 1 taproot input).