Misc fixes for generating examples

[rustyrussell]

All the issues I found while trying to make deterministic core lightning runs.

1. A crash when we splice a confirmed-but-unannounced channel.
2. listtransactions not noticing when a sendpsbt transaction gets mined, if there are no outputs to us.
3. Improve robustness of notleak() macro so we can use it very early.
4. Make --dev-save-plugin-io more robust against restarts, by including timestamp in filename.
5. Remove unused functions and fields.
6. Fix benchmark routines to use timemono not timeabs.
7. Fix invalid output in scb files (to do with last seen address).

[ddustin]

Do you have more the log handy for this crash? 9d76481

[rustyrussell]

Do you have more the log handy for this crash? 9d76481

You can reproduce it yourself on master using this test. However, it was pretty clear, and the next commit fixes it...

[ddustin]

LGTM except this weird CI failure -> https://github.com/ElementsProject/lightning/actions/runs/18181239624/job/51760146749?pr=8555

FAILED tests/test_splicing.py::test_splice_unannounced - pyln.client.lightning.RpcError: RPC call failed: method:
splice_update,
payload:{
 'channel_id': '1070a78b714290108ed590cd5bc5792d9c33096a9e56c66b6879e280ebe135d9',
 'psbt': 'cHNldP8BAgQCAAAAAQMEZwAAAAEEAQIBBQEDAQYBAwH7BAIAAAAAAQFCAVznuWPTf48tUcr7upKKqp4iC4u8ZgVxSZwDYoo4UbjOAQAAAAAADyKkABYAFMLMqxccKlvp2rUuxBuCWGMCTFRmAQ4gEHCni3FCkBCO1ZDNW8V5LZwzCWqeVsZraHnigOvhNdkBDwQBAAAAARAE/f///wz8CWxpZ2h0bmluZwEIFGRQGwtPqrIAAQDwAgAAAAABmtOmhRkUqWhL0Jz4z7SGBQzmCPbotH64ClYAVlgvOd8BAAAAAP3///8DAVznuWPTf48tUcr7upKKqp4iC4u8ZgVxSZwDYoo4UbjOAQAAAAAAD0JAACIAIFuM07kUz2fN2Ppic8kwNT3TZHZzT72WIQLC31O5CIDNAVznuWPTf48tUcr7upKKqp4iC4u8ZgVxSZwDYoo4UbjOAQAAAAAADyKkABYAFMLMqxccKlvp2rUuxBuCWGMCTFRmAVznuWPTf48tUcr7upKKqp4iC4u8ZgVxSZwDYoo4UbjOAQAAAAAAAB+cAABmAAAAAQFOAVznuWPTf48tUcr7upKKqp4iC4u8ZgVxSZwDYoo4UbjOAQAAAAAAD0JAACIAIFuM07kUz2fN2Ppic8kwNT3TZHZzT72WIQLC31O5CIDNAQVHUiECMkJm3oQDs6sVegnx94TVh69hgxyZjBUbzCG7dMKyMUshAuO9OACYZsnajsSqmcxOqcbA3UbfFcYe8M4fJxKRcU5XUq4BDiAQcKeLcUKQEI7VkM1bxXktnDMJap5WxmtoeeKA6+E12QEPBAAAAAABEAQAAAAADPwJbGlnaHRuaW5nAQinEkBq/HGQCAABAwiBbg0AAAAAAAEEFgAU1rlp023/2tmGkZP2Y+5IDf3HNIgH/ARwc2V0AiBc57lj03+PLVHK+7qSiqqeIguLvGYFcUmcA2KKOFG4zgz8CWxpZ2h0bmluZwEIXxADWpMm9qYAAQMIWwoAAAAAAAABBAAH/ARwc2V0AiBc57lj03+PLVHK+7qSiqqeIguLvGYFcUmcA2KKOFG4zgz8CWxpZ2h0bmluZwEIFS3gMVW4k/AAAQMI4MgQAAAAAAABBCIAIFuM07kUz2fN2Ppic8kwNT3TZHZzT72WIQLC31O5CIDNB/wEcHNldAIgXOe5Y9N/jy1Ryvu6koqqniILi7xmBXFJnANiijhRuM4M/AlsaWdodG5pbmcBCE4A/b4fKO3yAA=='},
error: {
 'code': 363,
 'message':
 'Splice command failed: Splice update error: interactivetx ADD_INPUT PSBT needs the previous transaction set.'}

This happens because interactivetx sees an input without the prevtx loaded. Most likely this is for the input spending the funding outpoint.

This is loaded from channeld via bitcoin_tx_from_txid, which asks lightningd with towire_channeld_splice_lookup_tx, which in turn calls wallet_transaction_get with the txid.

This is querying the database SELECT rawtx FROM transactions WHERE id=[txid].

Is it possible there is some flow where the funding tx doesn't make it into the transactions table in time? 🤔

In the same run we're seeing these failures, perhaps they provide a clue:

test_sendpsbt_confirm[False]
Error broadcasting transaction: error code: -26\\nerror message:\\nbad-txns-in-ne-out, value in != value out. Unsent tx discarded 

test_sendpsbt_confirm[True]
Error broadcasting transaction: error code: -26\\nerror message:\\nbad-txns-in-ne-out, value in != value out. Unsent tx discarded 

[rustyrussell]

LGTM except this weird CI failure -> https://github.com/ElementsProject/lightning/actions/runs/18181239624/job/51760146749?pr=8555

FAILED tests/test_splicing.py::test_splice_unannounced - pyln.client.lightning.RpcError: RPC call failed: method:
splice_update,
payload:{
 'channel_id': '1070a78b714290108ed590cd5bc5792d9c33096a9e56c66b6879e280ebe135d9',
 'psbt': 'cHNldP8BAgQCAAAAAQMEZwAAAAEEAQIBBQEDAQYBAwH7BAIAAAAAAQFCAVznuWPTf48tUcr7upKKqp4iC4u8ZgVxSZwDYoo4UbjOAQAAAAAADyKkABYAFMLMqxccKlvp2rUuxBuCWGMCTFRmAQ4gEHCni3FCkBCO1ZDNW8V5LZwzCWqeVsZraHnigOvhNdkBDwQBAAAAARAE/f///wz8CWxpZ2h0bmluZwEIFGRQGwtPqrIAAQDwAgAAAAABmtOmhRkUqWhL0Jz4z7SGBQzmCPbotH64ClYAVlgvOd8BAAAAAP3///8DAVznuWPTf48tUcr7upKKqp4iC4u8ZgVxSZwDYoo4UbjOAQAAAAAAD0JAACIAIFuM07kUz2fN2Ppic8kwNT3TZHZzT72WIQLC31O5CIDNAVznuWPTf48tUcr7upKKqp4iC4u8ZgVxSZwDYoo4UbjOAQAAAAAADyKkABYAFMLMqxccKlvp2rUuxBuCWGMCTFRmAVznuWPTf48tUcr7upKKqp4iC4u8ZgVxSZwDYoo4UbjOAQAAAAAAAB+cAABmAAAAAQFOAVznuWPTf48tUcr7upKKqp4iC4u8ZgVxSZwDYoo4UbjOAQAAAAAAD0JAACIAIFuM07kUz2fN2Ppic8kwNT3TZHZzT72WIQLC31O5CIDNAQVHUiECMkJm3oQDs6sVegnx94TVh69hgxyZjBUbzCG7dMKyMUshAuO9OACYZsnajsSqmcxOqcbA3UbfFcYe8M4fJxKRcU5XUq4BDiAQcKeLcUKQEI7VkM1bxXktnDMJap5WxmtoeeKA6+E12QEPBAAAAAABEAQAAAAADPwJbGlnaHRuaW5nAQinEkBq/HGQCAABAwiBbg0AAAAAAAEEFgAU1rlp023/2tmGkZP2Y+5IDf3HNIgH/ARwc2V0AiBc57lj03+PLVHK+7qSiqqeIguLvGYFcUmcA2KKOFG4zgz8CWxpZ2h0bmluZwEIXxADWpMm9qYAAQMIWwoAAAAAAAABBAAH/ARwc2V0AiBc57lj03+PLVHK+7qSiqqeIguLvGYFcUmcA2KKOFG4zgz8CWxpZ2h0bmluZwEIFS3gMVW4k/AAAQMI4MgQAAAAAAABBCIAIFuM07kUz2fN2Ppic8kwNT3TZHZzT72WIQLC31O5CIDNB/wEcHNldAIgXOe5Y9N/jy1Ryvu6koqqniILi7xmBXFJnANiijhRuM4M/AlsaWdodG5pbmcBCE4A/b4fKO3yAA=='},
error: {
 'code': 363,
 'message':
 'Splice command failed: Splice update error: interactivetx ADD_INPUT PSBT needs the previous transaction set.'}

This happens because interactivetx sees an input without the prevtx loaded. Most likely this is for the input spending the funding outpoint.

This is loaded from channeld via bitcoin_tx_from_txid, which asks lightningd with towire_channeld_splice_lookup_tx, which in turn calls wallet_transaction_get with the txid.

This is querying the database SELECT rawtx FROM transactions WHERE id=[txid].

Is it possible there is some flow where the funding tx doesn't make it into the transactions table in time? 🤔

In the same run we're seeing these failures, perhaps they provide a clue:

test_sendpsbt_confirm[False]
Error broadcasting transaction: error code: -26\\nerror message:\\nbad-txns-in-ne-out, value in != value out. Unsent tx discarded 

test_sendpsbt_confirm[True]
Error broadcasting transaction: error code: -26\\nerror message:\\nbad-txns-in-ne-out, value in != value out. Unsent tx discarded 

Can't be, because then we'd hit this:

	channel_internal_error(channel,
			       "channel control unable to find txid %s",
			       fmt_bitcoin_txid(tmpctx, &txid));