testing: Suppress logging exceptions when pytest captures output #8843
+238
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only record trace events that take at least 1 second, reducing noise from hundreds of tiny quick operations. This makes the trace output cleaner and easier to analyze by focusing on the actual bottlenecks.
Flow events now correctly use 'ph': 's' (flow start) for the parent endpoint and 'ph': 'f' (flow finish) for the child endpoint. This follows the Chrome Trace Event Format specification for well-formed flows. Removed redundant bind_id field.
cdecker
force-pushed
the
202601-logging-denoise
branch
from
f832c6d to
9f468a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with the logging library raising exceptions when pytest swaps out sys.stdout/sys.stderr for output capture.
Changes
TEST_LOG_IGNORE_ERRORSenvironment variable to disablelogging.raiseExceptionsin the test setup fixtureTEST_LOG_IGNORE_ERRORS=1in:.github/workflows/ci.yaml).github/workflows/coverage-nightly.yaml)Problem
The logging library was raising exceptions when pytest captured output by temporarily replacing sys.stdout/sys.stderr. This caused test failures due to logging handlers attempting to write to closed file descriptors.
Solution
When
TEST_LOG_IGNORE_ERRORS=1is set, the test fixture now disableslogging.raiseExceptions, allowing tests to continue even if logging encounters errors during pytest's output capture.