Skip to content

Conversation

@Impa10r
Copy link
Contributor

@Impa10r Impa10r commented Apr 3, 2025

lnd and cln now support testnet4 lightningnetwork/lnd#9620, ps should too

Copy link
Contributor

@YusukeShimizu YusukeShimizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that the same consideration is necessary for validateNetwork as well.
https://github.com/ElementsProject/peerswap/blob/master/swap/messages.go#L123

Could you please check if the swap is functioning properly?

Also, could you handle the corresponding change on the CLN side? It seems that support for testnet4 was recently added ElementsProject/lightning#8171.

@Impa10r
Copy link
Contributor Author

Impa10r commented Apr 4, 2025

thanks. updated and confirm working with lnd. struggling to test with cln so far: #370

@Impa10r
Copy link
Contributor Author

Impa10r commented Apr 9, 2025

tested swaps between LND and CLN, thanks to this PR: #371

@YusukeShimizu
Copy link
Contributor

Would you mind reverting that merge commit and rebasing instead?

@Impa10r
Copy link
Contributor Author

Impa10r commented Apr 14, 2025

Would you mind reverting that merge commit and rebasing instead?

took a few tries with chatgpt, but I think I finally got what you asked. thanks for teaching me something new! the branch works fine with cln and lnd...

Copy link
Contributor

@YusukeShimizu YusukeShimizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
The changes are limited to non-production areas (tests), so there’s no impact on runtime behavior or mainnet-facing code. All checks pass, so I’m approving.

@YusukeShimizu YusukeShimizu merged commit 38abd64 into ElementsProject:master Jun 9, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants