test: improve debugging for WaitForLog timeouts #391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YusukeShimizu
force-pushed
the
debug-cln-startup-timeout
branch
from
5d4e8e9 to
7e8852f
Compare
The integration tests often fail when waiting for the CLN node to log "Server started with public key". Therefore, I fixed the observability and corrected the path, as the issue was probably caused by the Unix domain socket being too long. Unix domain sockets are limited to 108 bytes. The former path (~115 chars) The new scheme generates a much shorter path (~46 chars) /tmp/ps/<pid>-<rand>/c1/regtest/lightning-rpc
YusukeShimizu
force-pushed
the
debug-cln-startup-timeout
branch
from
6afe989 to
d336e45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration tests often fail when waiting for the CLN node to
log "Server started with public key".
I fixed the observability and corrected the path,
as the issue was probably caused by the Unix domain socket being too long.
Unix domain sockets are limited to 108 bytes.
The former path (~115 chars)
The new scheme generates a much shorter path (~46 chars)
/tmp/ps/<pid>-<rand>/c1/regtest/lightning-rpc