fix: resolve flaky recovery tests by ensuring block sync #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure taker node is fully synced with the latest block height before starting recovery process. This prevents race conditions where the recovery might start before the node recognizes it has passed the CSV timeout, causing flaky test failures. The issue occurred when the node restarted and immediately began recovery without being aware of the blocks generated while it was offline, leading to inconsistent CSV timeout detection. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flaky test failures in
Test_Recover_PassedSwap_BTCandTest_Recover_PassedSwap_LBTCAdds block height synchronization after node restart to ensure consistent CSV timeout detection.