discount: fix weight calculation #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoelstra
added a commit
to ElementsProject/ELIPs
that referenced
this pull request
Sep 27, 2024
9f08b81 elip200: fix discount weight calculation for asset and nonce (Byron Hambly) Pull request description: output amount and nonce discount must be weighted by the witness scaling factor as they form part of the base transaction, not the witness data see ElementsProject/elements#1366 and ElementsProject/rust-elements#218 ACKs for top commit: apoelstra: ACK 9f08b81 Tree-SHA512: c719cd0343887d11b28037cb1b15da73b9d139f95a8c75bb91dd8ea126ed8cf8781485dd6ef26304adb8cd1a08b60c4ee0a14480f25619950f67a1d394d64e3e
|
link to #204 too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
output amount and nonce discount must be weighted by the witness scaling factor as they form part of the base transaction, not the witness data
see ElementsProject/elements#1366