Skip to content

Fix with jasmine#110

Merged
luciaquirke merged 3 commits intomainfrom
jasmine-fix
Jan 6, 2026
Merged

Fix with jasmine#110
luciaquirke merged 3 commits intomainfrom
jasmine-fix

Conversation

@luciaquirke
Copy link
Collaborator

@luciaquirke luciaquirke commented Jan 5, 2026 •
edited
Loading

  • Remove redundant code
  • Use a larger dtype for scores (float32 or 64)
  • Validate run path in score

@luciaquirke luciaquirke force-pushed the jasmine-fix branch 2 times, most recently from 1af42d6 to bf15c28 Compare January 6, 2026 00:15
luciaquirke
luciaquirke commented Jan 6, 2026
View reviewed changes
bergson/score/score.py Outdated

try:
mmap = load_gradients(Path(score_cfg.query_path), structured=False)
mmap = load_gradients(Path(score_cfg.query_path), structured=True)
Copy link
Collaborator Author

@luciaquirke luciaquirke Jan 6, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO remove structured=True option
TODO release package + get in on pypi

@luciaquirke luciaquirke force-pushed the jasmine-fix branch 2 times, most recently from f0a2fad to e2e4265 Compare January 6, 2026 00:27
@luciaquirke luciaquirke requested a review from LouisYRYJ January 6, 2026 00:27
@luciaquirke luciaquirke merged commit f4df7b3 into main Jan 6, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LouisYRYJ LouisYRYJ Awaiting requested review from LouisYRYJ

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@luciaquirke