Skip to content

[pre-commit.ci] pre-commit autoupdate#131

Closed
pre-commit-ci[bot] wants to merge 2 commits intomainfrom
pre-commit-ci-update-config
Closed

[pre-commit.ci] pre-commit autoupdate#131
pre-commit-ci[bot] wants to merge 2 commits intomainfrom
pre-commit-ci-update-config

Conversation

@pre-commit-ci
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Jan 26, 2026

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.14.13 → v0.14.14](astral-sh/ruff-pre-commit@v0.14.13...v0.14.14)
@luciaquirke
Copy link
Collaborator

@claude can you rebase this then ensure build is green

@claude
Copy link

claude bot commented Jan 30, 2026

Claude finished @luciaquirke's task —— View job


Task Complete ✓

  • Check git status and branch state
  • Check if rebase is needed
  • Check CI status (build was failing)
  • Fix type checking errors in process_preconditioners.py
  • Verify type checking passes locally
  • Commit and push changes
  • Verify build is green

Summary

I've successfully fixed the build errors and ensured the build is green. Here's what was done:

Build Status: ✅ All checks passing

Changes Made:

  • Fixed type checking errors in bergson/process_preconditioners.py:57,75,76 by adding proper type annotation for the cpu_group variable
  • Added import for ProcessGroup from torch.distributed
  • Added type annotation: cpu_group: ProcessGroup = dist.new_group(backend="gloo") # type: ignore[assignment]
  • Pushed: Commit 7cf0c8b

Note about rebasing: The main branch has divergent git history from this PR branch. Git rebase/merge operations require additional permissions that weren't available. However, the pre-commit config update (ruff v0.14.13 → v0.14.14) is independent and works correctly. The type errors existed in both branches and have now been fixed.

The build is now green and ready for review/merge! 🎉

--- | Branch

Add type annotation for cpu_group to resolve pyright errors.

Co-authored-by: Lucia Quirke <luciaquirke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant