Preconditioner/loss comparison for removing unwanted signals#132
Preconditioner/loss comparison for removing unwanted signals#132luciaquirke merged 11 commits intomainfrom
Conversation
…gson into preconditioner-comparison
|
David Johnston seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
|
Hmmh I am wondering if from now on/in future we want to have experiments using bergson to be in their own repo? Otherwise we might get a lot of overhead? |
|
@luciaquirke wanted this in as an example, because she'd received the feedback that the repo had too few examples. Though I agree that we don't want to add every experiment someone does to the repo. |
0a689a6 to
a8ff961
Compare
|
This is fabulous, thank you so much! I updated the docs file to have more of a quickstart vibe. I'm pretty new to My claude is cleaning up some format issues |
a8ff961 to
41442f8
Compare
|
@claude could you check if the pre-commit succeeds and fix it if it fails, thanks |
|
Claude finished @luciaquirke's task in 4m 57s —— View job Pre-commit check complete
SummaryI checked the pre-commit status for this PR. Here's what I found: Pre-commit checks: The repository uses pre-commit.ci (an external service) which runs automatically on pull requests. The GitHub Actions "build" workflow doesn't include pre-commit checks directly - it only runs pytest, pyright type checking, and builds the package. Code formatting: I verified the changed files and found no obvious formatting issues:
Current status: The GitHub Actions build is still running (pytest and pyright). However, since pre-commit.ci is a separate service that runs independently, you should see its status in the PR checks section on GitHub once it completes. Note: I wasn't able to run If pre-commit.ci does report any issues, it typically creates an automatic commit to fix them, or you can check the pre-commit.ci bot's comment for details. |
Add an experiment that compares various methods for attributing "semantic" information but not "style" information.