Add additional asserts and update post training readme #1300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quentin-Anthony
approved these changes
Oct 8, 2024
jahatef
pushed a commit
that referenced
this pull request
Oct 31, 2024
* add asserts and fix post training readme * precommit --------- Co-authored-by: Quentin Anthony <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Add an assert to block dpo/kto/rm training when running pipeline parallel, as get_batch_pipe does not have the relevant logic yet
-Add assert when kto + train_micro_batch_size_per_gpu == 1 since kto needs a reference
-remove python post-training/llama_dpo_data.py as this file does not exist and is not nessesary to get the code running