Skip to content

Resolve Transformer Engine SwiGLU Issue #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

aurelion-source
Copy link
Contributor

Resolves #1347

  • TE configures the activation function internally via the "activation" argument. Removed redundant manual activation logic.
  • Cleaned up unnecessary dimension calculations. These are also performed internally by TE.

Tested for functionality and loss with TE v2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Use SwiGLU with Transformer Engine
1 participant