fix: undefined self.args in TopKTokenChoiceRouter.jitter#1372
Open
Mr-Neutr0n wants to merge 1 commit intoEleutherAI:mainfrom
Open
fix: undefined self.args in TopKTokenChoiceRouter.jitter#1372Mr-Neutr0n wants to merge 1 commit intoEleutherAI:mainfrom
Mr-Neutr0n wants to merge 1 commit intoEleutherAI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
TopKTokenChoiceRouter.jitter()referencesself.args.moe_jitter_eps, butself.argsis never assigned in the constructor. This causes anAttributeErrorat runtime when jitter noise is applied during training.The constructor already stores the value as
self.jitter_eps = neox_args.moe_jitter_eps, but thejitter()method does not use it.Fix
Changed
self.args.moe_jitter_epstoself.jitter_epsin thejitter()method to reference the attribute that is actually set in__init__.