fix(aime): ensure non-empty prompt for API backends#3555
Open
jayvenn21 wants to merge 1 commit intoEleutherAI:mainfrom
Open
fix(aime): ensure non-empty prompt for API backends#3555jayvenn21 wants to merge 1 commit intoEleutherAI:mainfrom
jayvenn21 wants to merge 1 commit intoEleutherAI:mainfrom
Conversation
Co-authored-by: Cursor <[email protected]>
Author
|
Note: this does not force apply_chat_template; API users should still pass it when evaluating chat/instruct models. This PR only guarantees a non-empty base prompt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix AIME'24 empty prompt for API backends
This PR fixes an issue where AIME'24 tasks generate an empty prompt when evaluated using OpenAI-style / local-completions backends, causing API errors like:
HF local models tolerate empty prompts, but API backends do not.
Changes
doc_to_textalways returns a non-empty prompt (instructional prefix: "Solve the following AIME problem.")aime24,aime, andaime25with correct dataset fields (Problem/Question/problem)tests/test_aime_prompt.pyto prevent future empty promptsRelated issue
Fixes #3497