Fix correctness issues in Arabic normalization and prompt loading#3589
Open
RinZ27 wants to merge 1 commit intoEleutherAI:mainfrom
Open
Fix correctness issues in Arabic normalization and prompt loading#3589RinZ27 wants to merge 1 commit intoEleutherAI:mainfrom
RinZ27 wants to merge 1 commit intoEleutherAI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several correctness issues were identified during a deep dive into the codebase, specifically affecting Arabic normalization, prompt loading, and logging hygiene.
Key changes:
mlqa/utils.py. The previous regex had a misplaced caret and was overly aggressive, which could lead to corrupted word forms.elseblock inlm_eval/prompts/__init__.pyto provide a clearer error message when an unknown prompt category is used, preventing a potentialUnboundLocalError.print(prompt)statement inmed_prescriptions/utils.pyto keep evaluation logs clean and protect potential PII in medical datasets.x = x) in therulertask module to improve code clarity.Verified the fixes by running the
test_utils.pysuite and confirmed everything passes correctly. These improvements directly benefit evaluation accuracy and project robustness.