fix display decimals #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
throwbackjams
approved these changes
Feb 9, 2023
Contributor
throwbackjams
left a comment
throwbackjams
left a comment
There was a problem hiding this comment.
In a future PR, will add ability to read and adjust calc based on raw_base_units_per_base_unit
eugene-chen
requested changes
Feb 17, 2023
| } | ||
|
|
||
| pub fn get_precision(mut target: u64) -> usize { | ||
| let is_prime = |x| { |
Contributor
There was a problem hiding this comment.
this seems overly complicated. why not just divide by 2 until it's no longer divisible by 2, and divide by 5 until it's no longer divisible by 5?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.