feat: Strict solana cli version #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for PR! This is great idea. In order to be backwards compatible, what if we made this only accessible through new |
Contributor
Author
I believe given the goal of this tool not being strict is a bug, adding the flag make it more cumbersome for standard use: strict verification I hit myself another case of building with wrong cli today |
Arrowana
force-pushed
the
feat/strict-solana-cli-version
branch
from
f7992cd to
b0e8d18
Compare
Collaborator
|
lgtm! |
|
Agree |
|
projectserum/build@sha256:75b75eab447ebcca1f471c98583d9b5d82c4be122c470852a022afcf9c98bead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Picking a solana cli version that is <= makes verifying dependent on the solana-verify version installed
Solution
Strict solana-cli version