fix: Handle exit code success

[Arrowana]

Problem

The API of Command looks misunderstood, it does not err on exit code not being a success but only if invocation of the command itself fails (command not found...).

This leads to messed up CLI output, one has to read what happened above to deduce the actual real outcome of the command since it continues on failure silently.

A typical case is compilation failure then a program hash gets printed.

I think this can be more serious in some cases where a sequence of actions can lead to garbage unrelated hash in silence.

Solution

Unfortunately there is no direct api it seems to err on status code. Use ensure! macro to validate the success

I didn't use the status code on anything that looks like a cleanup to avoid a failure and further cleanup

[ngundotra]

Reviewing this today. Do you have a command for me to check that this PR works?

[jasonslagter]

Need

[jasonslagter]

Problem

The API of Command looks misunderstood, it does not err on exit code not being a success but only if invocation of the command itself fails (command not found...).

This leads to messed up CLI output, one has to read what happened above to deduce the actual real outcome of the command since it continues on failure silently.

A typical case is compilation failure then a program hash gets printed.

I think this can be more serious in some cases where a sequence of actions can lead to garbage unrelated hash in silence.

Solution

Unfortunately there is no direct api it seems to err on status code. Use ensure! macro to validate the success

I didn't use the status code on anything that looks like a cleanup to avoid a failure and further cleanup

[swaroop-osec]

• Please bump the crate version in Cargo.toml to "0.4.4"
• It would be great to run cargo clippy and apply suggestions to keep the codebase clean and idiomatic.
• Consider adding more descriptive error messages to the ensure! macros. This will improve debugging and make logs clear.

[swaroop-osec]

@Arrowana This works well as intended, verified locally. Requested a few minor changes to polish it up.
CC: @ngundotra

[swaroop-osec]

lgtm

[jasonslagter]

.