feat: add --arch flag support for cargo build-sbf commands #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add --arch flag to build, verify-from-repo, export-pda-tx, and remote submit-job commands to support targeting specific virtual machine architectures (v0-v3). The flag is passed through to cargo build-sbf during builds and to remote verification services. Closes Ellipsis-Labs#195
Collaborator
|
@tracy-codes Can you bump the version please? |
swaroop-osec
requested changes
Aug 20, 2025
src/api/client.rs
Outdated
| }); | ||
|
|
||
| // Add arch parameter if provided | ||
| if let Some(arch_value) = arch { |
Collaborator
There was a problem hiding this comment.
Since we’ll be retrieving the arch value from the program’s PDA, could you remove the extra argument here?
src/main.rs
Outdated
| .required(true) | ||
| .takes_value(true) | ||
| .help("This is the address that uploaded verified build information for the program-id"))) | ||
| .help("This is the address that uploaded verified build information for the program-id")) |
Collaborator
There was a problem hiding this comment.
The same applies here; the extra argument can be removed
Signed-off-by: Tracy Adams <[email protected]>
swaroop-osec
approved these changes
Aug 21, 2025
Collaborator
|
@ngundotra lgtm |
ngundotra
approved these changes
Aug 21, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for the
--archflag that was recently added tocargo build-sbf, resolving issue #195.Changes Made
Added
--archflag to CLI commands:solana-verify build --arch <v0|v1|v2|v3>solana-verify verify-from-repo --arch <v0|v1|v2|v3>solana-verify export-pda-tx --arch <v0|v1|v2|v3>Updated function signatures to pass the arch parameter through the entire build pipeline
Integrated with Docker builds to pass
--archflag tocargo build-sbfwhen specifiedAdded remote verification support to include arch parameter in API calls
Added proper help text indicating the default value is
v0Usage Examples
Implementation Details
The
--archflag accepts valuesv0,v1,v2,v3(matchingcargo build-sbfoptions) withv0as the default. When specified, the flag is passed to the underlyingcargo build-sbfcommand during Docker-based builds.Closes #195