handle missing lib gracefully #217
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if you provide an incorrect value to
--library, the cli ignores it and runscargo build-sbfat the toplevel. but then at the end it tries to use the library to locate the elf file to hash. the cli prints "Error: Failed to parse output" and exits. in practice what this has meant is thinking "did it fail? huh, no seems like it worked. yay!" and then a month later realizing you have five running docker containers 😅instead, print a helpful message and continue to
docker kill(incidentally the reason it printed "Failed to parse output" instead of "Failed to find program" is because
find x -name youtputs nothing and returns 0 if y doesnt exist. it will however return 1 if x doesnt exist)