feat: verifiable-build.toml to specify solana version#233
Open
Arrowana wants to merge 1 commit intoEllipsis-Labs:masterfrom
Open
feat: verifiable-build.toml to specify solana version#233Arrowana wants to merge 1 commit intoEllipsis-Labs:masterfrom
Arrowana wants to merge 1 commit intoEllipsis-Labs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
looking for solana_program inside the lock is not very accurate and does not work in new programs that do not even use solana_program
Solution
Introduce a config file to specify the solana cli version explicitly so that the desired version can be baked into the codebase instead of relying on
--base-image