Move CI on Windows/MSYS2 from the MINGW64 to the UCRT64 environment #748
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Microsoft started to re-implement their C runtime for Windows 10 (UCRT). That newer variant of the C runtime can be installed as an optional update on Windows 7 and later. Among other things, the UCRT has better support for some standard functions comapared to the previous C runtimes (MSVCRT). The MINGW64 environment of MSYS2 is based on the MSVCRT which is also supported on even older versions of Windows. Their UCRT64 environment is based on the newer C runtime (UCRT). Some packagers of MSYS2 are pushing towards removing more and more packages from their MINGW64 environment. Move the CI to the UCRT64 environment which probably is the more reasonable one for targeting all current Windows systems anyway. This requires installing a few more (optional runtime) dependencies of VTK which are required dependencies when linking against VTK.
Contributor
Author
|
I'm not sure why some of the tests failed here. They were passing for me locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft started to re-implement their C runtime for Windows 10 (UCRT). That newer variant of the C runtime can be installed as an optional update on Windows 7 and later.
Among other things, the UCRT has better support for some standard functions compared to the previous C runtimes (MSVCRT).
The MINGW64 environment of MSYS2 is based on the MSVCRT which is also supported on even older versions of Windows. Their UCRT64 environment is based on the newer C runtime (UCRT). Some packagers of MSYS2 are pushing towards removing more and more packages from their MINGW64 environment.
Move the CI to the UCRT64 environment which probably is the more reasonable one for targeting all current Windows systems anyway.
This requires installing a few more (optional runtime) dependencies of VTK which are required dependencies when linking against VTK.