Skip to content

Fix MSYS2 GitHub action#20

Merged
rsp4jack merged 3 commits intoEmbeddedSynth:develfrom
pedrolcl:fix-msys2-github-action
Feb 13, 2026
Merged

Fix MSYS2 GitHub action#20
rsp4jack merged 3 commits intoEmbeddedSynth:develfrom
pedrolcl:fix-msys2-github-action

Conversation

@pedrolcl
Copy link
Copy Markdown
Collaborator

Description

Avoid overriding TEMP environment variable; transform msys2 TEMP using cygpath.

Related Issues

Closes #18

Checklist

  • I have followed the contribution guidelines.
  • My code follows the coding standards.
  • I have tested my changes.

@pedrolcl pedrolcl requested a review from rsp4jack February 12, 2026 21:38
@rsp4jack
Copy link
Copy Markdown
Collaborator

https://github.com/EmbeddedSynth/sonivox/actions/runs/21965245212/job/63453251386?pr=20

At Configure CMake step:

cmake -B build -G Ninja -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_INSTALL_PREFIX=SonivoxV4 -DDEPENDENCY_DIRS=C:\msys64/mingw64/bin -DCPACK_SYSTEM_NAME=mingw64 -DINSTALL_DEPENDENCIES=ON

-- DEPENDENCY_DIRS: C:msys64/mingw64/bin

Does it actually work? If not, cygpath should also be used for DEPENDENCY_DIRS.

@pedrolcl
Copy link
Copy Markdown
Collaborator Author

Thanks for the heads up!

-- DEPENDENCY_DIRS: C:msys64/mingw64/bin

Does it actually work? If not, cygpath should also be used for DEPENDENCY_DIRS.

The NSIS installer program created by cpack does indeed work:
https://github.com/EmbeddedSynth/sonivox/actions/runs/21965245212/artifacts/5490438127
image

but anyway, I've pushed another commit transforming DEPENDENCY_DIRS with cygpath. This is used by CMake to resolve dependencies (in this case, zlib only) and I believe that works even if not specified or invalid, because it is in the $PATH.

@rsp4jack rsp4jack merged commit f46c9e4 into EmbeddedSynth:devel Feb 13, 2026
18 checks passed
@pedrolcl pedrolcl deleted the fix-msys2-github-action branch February 13, 2026 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

failing MSYS2 github workflow action

2 participants