task_runner: task: mark arg as device pointer #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add option to mark the task argument as a device pointer. If done so, the device is validated in `task_runner_init`, with the task always skipped if the device failed to initialise. Signed-off-by: Jordan Yates <[email protected]>
Add a test for the `TASK_FLAG_ARG_IS_DEVICE` task flag. Signed-off-by: Jordan Yates <[email protected]>
Use the new device pointer feature for tasks that use devices. Signed-off-by: Jordan Yates <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
==========================================
+ Coverage 92.16% 92.17% +0.01%
==========================================
Files 104 104
Lines 3943 3949 +6
Branches 619 622 +3
==========================================
+ Hits 3634 3640 +6
Misses 156 156
Partials 153 153 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to mark the task argument as a device pointer. If done so,
the device is validated in
task_runner_init, with the task alwaysskipped if the device failed to initialise.
Use the new device pointer feature for tasks that use devices.