[EIS-448] gnss: gnss_ubx_modem: don't block system workqueue #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't block the system workqueue by performing the data read in the `.receive` function. Instead perform the read operation asynchronously as a continuation of the pending bytes query, placing the bytes into a FIFO. The receive callback then only needs to pull bytes from the FIFO. Signed-off-by: Jordan Yates <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
=======================================
Coverage 92.18% 92.18%
=======================================
Files 104 104
Lines 3952 3952
Branches 622 622
=======================================
Hits 3643 3643
Misses 156 156
Partials 153 153 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't block the system workqueue by performing the data read in the
.receivefunction. Instead perform the read operation asynchronously as a continuation of the pending bytes query, placing the bytes into a FIFO. The receive callback then only needs to pull bytes from the FIFO.