[EIS-452] nrf_modem_lib: optional caching of signal quality #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable the Nordic proprietary PSM mode for LTE to ensure we can still optimise power consumption when the LTE network does not natively support PSM. Signed-off-by: Jordan Yates <[email protected]>
Decrease the default accuracy required to report a location from 10km to 100km. This is still accurate enough for some purposes, and gives users an earlier indication of the approximate device position in challenging signal conditions. Signed-off-by: Jordan Yates <[email protected]>
Allow users to enable an optional fallback to the last valid queried signal parameters. This is useful for devices that spend most of their time in PSM mode, where parameters cannot be queried, but users still want some indication of the signal quality. The best we can do is the signal quality the last time we were on the network. In addition to caching the values when a user requests them, the cache is also automatically updated when the cell tower changes and when the connection transitions to active, in case no user request occurs while the connection is active. Signed-off-by: Jordan Yates <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
==========================================
+ Coverage 92.18% 92.19% +0.01%
==========================================
Files 104 104
Lines 3952 3961 +9
Branches 622 622
==========================================
+ Hits 3643 3652 +9
Misses 156 156
Partials 153 153 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to enable an optional fallback to the last valid queried
signal parameters. This is useful for devices that spend most of their
time in PSM mode, where parameters cannot be queried, but users still
want some indication of the signal quality. The best we can do is the
signal quality the last time we were on the network.
In addition to caching the values when a user requests them, the cache
is also automatically updated when the cell tower changes and when the
connection transitions to active, in case no user request occurs while
the connection is active.