Skip to content

Conversation

JordanYates
Copy link
Contributor

Add a software pre-warning to the watchdog module. This allows devices
with an uninterruptable reboot upon a hardware channel expiry (nRF) a
chance to execute a meaningful amount of work before rebooting.

Move functions we need to add additional functionality to into the `.c`
source file. As a side effect we can remove log module instantiations
from tests that use the watchdog.

Signed-off-by: Jordan Yates <[email protected]>
@JordanYates JordanYates changed the title watchdog: software pre-warning interrupt [EIS-486] watchdog: software pre-warning interrupt Oct 4, 2024
@JordanYates JordanYates changed the title [EIS-486] watchdog: software pre-warning interrupt [EIS-496] watchdog: software pre-warning interrupt Oct 4, 2024
@JordanYates JordanYates force-pushed the feature/watchdog_software_warn branch 2 times, most recently from fae7a81 to bfd6a2c Compare October 4, 2024 01:12
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 82.22222% with 8 lines in your changes missing coverage. Please review.

Project coverage is 92.13%. Comparing base (42867db) to head (6012945).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
drivers/watchdog/watchdog.c 84.09% 1 Missing and 6 partials ⚠️
lib/reboot.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
- Coverage   92.21%   92.13%   -0.08%     
==========================================
  Files         105      105              
  Lines        3980     4004      +24     
  Branches      623      629       +6     
==========================================
+ Hits         3670     3689      +19     
- Misses        157      158       +1     
- Partials      153      157       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Add a software pre-warning to the watchdog module. This allows devices
with an uninterruptable reboot upon a hardware channel expiry (nRF) a
chance to execute a meaningful amount of work before rebooting.

Signed-off-by: Jordan Yates <[email protected]>
Add a test for the behaviour of the watchdog pre-expiry software
warning.

Signed-off-by: Jordan Yates <[email protected]>
@JordanYates JordanYates force-pushed the feature/watchdog_software_warn branch from bfd6a2c to 6012945 Compare October 4, 2024 01:43
@JordanYates JordanYates merged commit 6a8d101 into main Oct 4, 2024
10 checks passed
@JordanYates JordanYates deleted the feature/watchdog_software_warn branch October 4, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant