Skip to content

Conversation

JordanYates
Copy link
Contributor

Shift the automatic SNTP runner to the asynchronous SNTP API to avoid blocking the system workqueue for seconds at a time.

Update zephyr fork with asynchronous SNTP implementation.

Signed-off-by: Jordan Yates <[email protected]>
Copy link

codecov bot commented Oct 5, 2024

Codecov Report

Attention: Patch coverage is 70.37037% with 8 lines in your changes missing coverage. Please review.

Project coverage is 91.26%. Comparing base (3955f48) to head (524ef6d).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
subsys/net/sntp/auto_sntp.c 70.37% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
- Coverage   91.29%   91.26%   -0.03%     
==========================================
  Files         105      105              
  Lines        4007     4020      +13     
  Branches      629      630       +1     
==========================================
+ Hits         3658     3669      +11     
- Misses        189      190       +1     
- Partials      160      161       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JordanYates JordanYates force-pushed the feature/async_sntp branch 3 times, most recently from ab55092 to ee0481b Compare October 5, 2024 04:47
Shift the automatic SNTP runner to the asynchronous SNTP API to avoid
blocking the system workqueue for seconds at a time.

Signed-off-by: Jordan Yates <[email protected]>
Test the behaviour of the SNTP timeout implementation.

Signed-off-by: Jordan Yates <[email protected]>
@JordanYates
Copy link
Contributor Author

COAP test server (coap.me) is currently down, otherwise tests passing

@JordanYates JordanYates merged commit 7282095 into main Oct 5, 2024
9 of 10 checks passed
@JordanYates JordanYates deleted the feature/async_sntp branch October 5, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant