Skip to content

Conversation

JordanYates
Copy link
Contributor

Defer processing of the NAV-PVT and NAV-TIMEGPS message to the main task
function to avoid running logging on the system workqueue. Logging on
the workqueue can fail in unexpected ways due to timeouts not being
respected in net_buf_get.

Defer processing of the NAV-PVT and NAV-TIMEGPS message to the main task
function to avoid running logging on the system workqueue. Logging on
the workqueue can fail in unexpected ways due to timeouts not being
respected in `net_buf_get`.

Signed-off-by: Jordan Yates <[email protected]>
Add a warning when attempting to log from the system workqueue, as this
can lead to deadlocks in application usage.

Signed-off-by: Jordan Yates <[email protected]>
Copy link

codecov bot commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.27%. Comparing base (3955f48) to head (f8ecaa4).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #271      +/-   ##
==========================================
- Coverage   91.29%   91.27%   -0.02%     
==========================================
  Files         105      105              
  Lines        4007     4024      +17     
  Branches      629      632       +3     
==========================================
+ Hits         3658     3673      +15     
- Misses        189      190       +1     
- Partials      160      161       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JordanYates
Copy link
Contributor Author

COAP test server (coap.me) is currently down, otherwise tests passing

@JordanYates JordanYates merged commit fe582b6 into main Oct 5, 2024
7 of 8 checks passed
@JordanYates JordanYates deleted the feature/defer_logging branch October 5, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant