Skip to content

Conversation

JordanYates
Copy link
Contributor

Update the default values for watchdog periods to give more of a window
for an idle thread to wake and feed the channel before expiry. Otherwise
if an alternate thread is always running for just
INFUSE_WATCHDOG_FEED_EARLY_MS, the watchdog may expire even though
nothing is wrong.

Fix the software warning handling inside of
`infuse_watchdog_thread_register`, and update tests to catch the error.

Signed-off-by: Jordan Yates <[email protected]>
Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.27%. Comparing base (fe582b6) to head (ce15b6a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #272   +/-   ##
=======================================
  Coverage   91.27%   91.27%           
=======================================
  Files         105      105           
  Lines        4024     4024           
  Branches      632      632           
=======================================
  Hits         3673     3673           
  Misses        190      190           
  Partials      161      161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Update the default values for watchdog periods to give more of a window
for an idle thread to wake and feed the channel before expiry. Otherwise
if an alternate thread is always running for just
`INFUSE_WATCHDOG_FEED_EARLY_MS`, the watchdog may expire even though
nothing is wrong.

Signed-off-by: Jordan Yates <[email protected]>
@JordanYates JordanYates force-pushed the bugfix/watchdog_timeout branch from 7e84a7e to ce15b6a Compare October 6, 2024 05:16
@JordanYates
Copy link
Contributor Author

COAP test server (coap.me) is currently down, otherwise tests passing

@JordanYates JordanYates merged commit 4acff7f into main Oct 6, 2024
9 of 10 checks passed
@JordanYates JordanYates deleted the bugfix/watchdog_timeout branch October 6, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant