Skip to content

Conversation

JordanYates
Copy link
Contributor

Add callbacks to be notified when application states change value.

Support running on Windows, which doesn't support `simple_term_menu`.

Signed-off-by: Jordan Yates <[email protected]>
Update zephyr fork with extra time defines.

Signed-off-by: Jordan Yates <[email protected]>
Fix handling of multiple calls to `infuse_state_set_timeout` and
interleaved calls between `infuse_state_set`, `infuse_state_set_timeout`
and `infuse_state_clear`.

Signed-off-by: Jordan Yates <[email protected]>
@JordanYates JordanYates requested a review from Aeyohan October 21, 2024 00:59
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 93.10345% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lib/states/application_states.c 93.10% 0 Missing and 4 partials ⚠️

📢 Thoughts on this report? Let us know!

Comment on lines 36 to 38
void infuse_state_unregister_callback(struct infuse_state_cb *cb)
{
sys_slist_find_and_remove(&cb_list, &cb->node);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be useful to just return bool from sys_slist_fine_and_remove.
Thoughts?

Add callbacks to be notified when application states change value.

Signed-off-by: Jordan Yates <[email protected]>
Add tests for the application state callbacks feature.

Signed-off-by: Jordan Yates <[email protected]>
@JordanYates JordanYates force-pushed the feature/states_callback branch from 68671ce to d02f6b4 Compare October 22, 2024 04:56
@JordanYates JordanYates merged commit 38930c7 into main Oct 22, 2024
11 checks passed
@JordanYates JordanYates deleted the feature/states_callback branch October 22, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants