task_runner: fix absolute timeout overflow #498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanYates
force-pushed
the
bugfix/absolute_overflows
branch
from
16370e5 to
1cc0f82
Compare
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Update zephyr fork to add `K_TIMEOUT_ABS_SEC`. Signed-off-by: Jordan Yates <[email protected]>
In the previous implementation, the `next_iter * MSEC_PER_SEC` calculation was operating on two `uint32_t`'s, which resulted in an integer overflow once the system uptime reached 49.71 days. Use the new `K_TIMEOUT_ABS_SEC` macro to avoid this. Also take the opportunity to make the function slightly more efficient by minimising conversions back and forth between different time units (milliseconds and ticks). Signed-off-by: Jordan Yates <[email protected]>
Add a test for the auto iterate functionality, which can be configured to run for arbitrary durations. Signed-off-by: Jordan Yates <[email protected]>
Transition any tests using `K_TIMEOUT_ABS_MS(1000*x)` to `K_TIMEOUT_ABS_SEC`. Signed-off-by: Jordan Yates <[email protected]>
JordanYates
force-pushed
the
bugfix/absolute_overflows
branch
from
1cc0f82 to
fc3c1bb
Compare
Aeyohan
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous implementation, the
next_iter * MSEC_PER_SECcalculation was operating on two
uint32_t's, which resulted in aninteger overflow once the system uptime reached 49.71 days.
Also take the opportunity to make the function slightly more efficient
by minimising conversions back and forth between different time units
(milliseconds and ticks).