task_runner: tasks: gnss_ubx: try comms reset #500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we don't get a MON-RXR message on wake, run a test command to validate comms on resume. This ensures that `pm_device_runtime_get` returns an error if comms is failing. Signed-off-by: Jordan Yates <[email protected]>
Move the PM function up in the file so we can refer to it from the init function. Signed-off-by: Jordan Yates <[email protected]>
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Move the PM functions to the common configuration struct so we don't need to pass around a `struct ubx_common_pm_fn*` everywhere. Signed-off-by: Jordan Yates <[email protected]>
Add a function to attempt to resynchronise communications with the u-blox modem without a physical power cycle. Signed-off-by: Jordan Yates <[email protected]>
If the initial `pm_device_runtime_get` function call fails, try and re-establish comms with the modem before giving up. Hopefully this resolves a looping error where the task keeps being restarted due to comms failures but never comes good. Signed-off-by: Jordan Yates <[email protected]>
Ensure that `ubx_modem_comms_reset` is called if `pm_device_runtime_get` fails on the first call. The task should then run successfully. Signed-off-by: Jordan Yates <[email protected]>
JordanYates
force-pushed
the
feature/gnss_hw_reset
branch
from
b8f52a8 to
d623e8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the initial
pm_device_runtime_getfunction call fails, try andre-establish comms with the modem before giving up. Hopefully this
resolves a looping error where the task keeps being restarted due to
comms failures but never comes good.