epacket: udp: provide cloud key IDs on decrypt fail #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If packet decryption from the cloud service fails, proactively send a `KEY_IDS` packet in response, since the most likely cause is out of date key information. Signed-off-by: Jordan Yates <[email protected]>
Proactively notify the cloud service of the current key identifiers on the first connection after boot. This resolves the first packet sent to the device after a complete erase cycle from failing to decrypt. Signed-off-by: Jordan Yates <[email protected]>
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If packet decryption from the cloud service fails, proactively send a
KEY_IDSpacket in response, since the most likely cause is out of date key information.Proactively notify the cloud service of the current key identifiers on the first connection after boot. This resolves the first packet sent to the device after a complete erase cycle from failing to decrypt.