tdf: explicit encoding format parameter #564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
JordanYates
force-pushed
the
feature/tdf_diff_rename
branch
from
9ded521 to
dd42bc9
Compare
Rather than having a dedicated logging parameter for diff types, make it a generic argument that can accept other encodings as well. Since `array_diff` is no longer the most specialised case, rename the core logging functions as `core` instead. Encoded data formats are not changed with this commit. Signed-off-by: Jordan Yates <[email protected]>
JordanYates
force-pushed
the
feature/tdf_diff_rename
branch
from
dd42bc9 to
7d493ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than having a dedicated logging parameter for diff types, make it a generic argument that can accept other encodings as well.
Since
array_diffis no longer the most specialised case, rename the core logging functions ascoreinstead.Encoded data formats are not changed with this commit.