apps: gateway_lte: disable LTE PSM mode #645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the macro argument when assigning the watchdog channel ID. Signed-off-by: Jordan Yates <[email protected]>
Registering the watchdog channel in the main function (which only starts after `main` executes) results in the watchdog channel attempting to be registered after the watchdog has already started. Use the registration macro to work fix this. Signed-off-by: Jordan Yates <[email protected]>
Make the buffer claim timeout configurable and extend the default value. This is intended to be a worst case scenario when all other watchdogs have failed to operate. Asserting from watchdogs etc is preferable because they provide more information about the root cause of the blockage, instead of just pointing at a symptom. Signed-off-by: Jordan Yates <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Logging trace events from `memfault_reboot_tracking_load` does not work since the trace module has not been initialised at that point. Defer the logging until 1 second later to ensure the event is logged properly. Extend the log message to also include registers R0-R3, and remove the deficated SFARVALID output, since that is encoded in SFSR. Signed-off-by: Jordan Yates <[email protected]>
LTE gateways should be always reachable when connected to a network. Signed-off-by: Jordan Yates <[email protected]>
JordanYates
force-pushed
the
feature/gw_lte_psm
branch
from
21120e0 to
ead044a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
watchdog: fix SYS_INIT macro
epacket: forwarding: fix watchdog registration
epacket: interfaces: udp: configurable buffer claim timeout
memfault: fix secure fault trace events
apps: gateway_lte: disable LTE PSM mode