reboot: fix alignment on RISCV #652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanYates
force-pushed
the
bugfix/reboot_alignment
branch
from
312ec17 to
0f23414
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
JordanYates
force-pushed
the
bugfix/reboot_alignment
branch
2 times, most recently
from
5c5aa69 to
18f0038
Compare
Ensure that the string provided to `LOG_INF` is NULL terminated, which is not necessarily true for `reboot_state.thread_name`. Signed-off-by: Jordan Yates <[email protected]>
Update thread names to be more specific and more concise, since some logging is limited to 8 byte names. Signed-off-by: Jordan Yates <[email protected]>
Ignore the `nrf54l09pdk` platform for now, since the naming of the SoC changed with the upgrade to NRFX v3.13.0 but Zephyr v4.1 still uses the original name. Signed-off-by: Jordan Yates <[email protected]>
RISCV platforms have a 16 byte alignment requirement for `arch_esf`. Reorganise the struct to achieve this with minimal overhead and add the necessary compiler directives. Signed-off-by: Jordan Yates <[email protected]>
JordanYates
force-pushed
the
bugfix/reboot_alignment
branch
from
18f0038 to
fe6bb16
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RISCV platforms have a 16 byte alignment requirement for
arch_esf. Reorganise the struct to achieve this with minimal overhead and add the necessary compiler directives.