treewide: lots of SonarQube fixes #654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix simple SonarQube warnings. Signed-off-by: Jordan Yates <[email protected]>
JordanYates
force-pushed
the
bugfix/sonarcube_misc
branch
from
f008bdf to
4c0289c
Compare
Extract functionality from some of the large functions to ease readability. Signed-off-by: Jordan Yates <[email protected]>
Remove casts for variables already of the type. Signed-off-by: Jordan Yates <[email protected]>
Return from the default. It has the same effect, but easier for tools to analyze apparently. Signed-off-by: Jordan Yates <[email protected]>
Add `const` qualifiers to functions that don't modify the arguments. Signed-off-by: Jordan Yates <[email protected]>
Add a `const` qualifier to function that doesn't modify args. Signed-off-by: Jordan Yates <[email protected]>
Fix multiple identifiers on one line. Signed-off-by: Jordan Yates <[email protected]>
Fix several easy SonarCube issues. Signed-off-by: Jordan Yates <[email protected]>
First steps towards simplifying `tdf_add_core`. Signed-off-by: Jordan Yates <[email protected]>
JordanYates
force-pushed
the
bugfix/sonarcube_misc
branch
from
4c0289c to
141d258
Compare
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a range of low priority SonarQube issues.