treewide: misc cleanup #657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a unique tag to autogenerated files such that analysis tools can ignore them if desired (`sonar.issue.ignore.allfile`). Signed-off-by: Jordan Yates <[email protected]>
Mark compile time constant string pointers as `const char *const`. Signed-off-by: Jordan Yates <[email protected]>
Validate that the base `key_type` falls within the expected range. Signed-off-by: Jordan Yates <[email protected]>
Since we're iterating over the string anyway, remove the initial `strlen` call. Signed-off-by: Jordan Yates <[email protected]>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
templates: add tag for autogenerated files
treewide: const-ify const char pointers
epacket: keys: validation on provided
key_typenet: coap: infuse_coap: remove
strlen