memfault: fix PC and LR for secure faults #659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For secure faults with full stack information, the PC and LR need to be pulled from a different location in the union. Signed-off-by: Jordan Yates <[email protected]>
Running `scanf` for a string of N characters requires an output buffer of (N + 1) characters (for the terminating NULL). Signed-off-by: Jordan Yates <[email protected]>
Ensure in software that the value read out of the KV store is NULL terminated before passing to `strlen`. Signed-off-by: Jordan Yates <[email protected]>
Add extra logic to ensure the buffer provided to `strlen` is NULL terminated. Signed-off-by: Jordan Yates <[email protected]>
One variable identifier per line. Signed-off-by: Jordan Yates <[email protected]>
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
memfault: fix PC and LR for secure faults
nrf_modem_lib: fix buffer size
nrf_modem_lib: ensure KV value NULL terminated
rpc: commands: lte_at_cmd: ensure NULL termination
gnss: ubx_modem: one identifier per line