treewide: sonarqube fixes #664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce the implementation complexity by adding a fallback struct which can be used to eliminate NULL checks. Signed-off-by: Jordan Yates <[email protected]>
Reduce the number of `infuse_security_derive_key` arguments by turning them into a struct. Signed-off-by: Jordan Yates <[email protected]>
Extract the core read loop logic into a dedicated function to simplify `epacket_udp_loop`. Signed-off-by: Jordan Yates <[email protected]>
Simplify `cartesian_point_in_polygon` by reducing nesting levels. Signed-off-by: Jordan Yates <[email protected]>
`bt_gatt_read` returns a full integer, so cannot use the `uint8_t` input variable for storage. Signed-off-by: Jordan Yates <[email protected]>
Simplify `opcode_run` by extracting the patch instruction implementation as already done in `do_copy` and `do_write`. Signed-off-by: Jordan Yates <[email protected]>
Validate the reconstructed payload matches the input buffer, in addition to checking the generation of the buffer. Signed-off-by: Jordan Yates <[email protected]>
Simplify the reconstructor function by extracting logic and reducing nesting. Signed-off-by: Jordan Yates <[email protected]>
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a variety of SonarQube issues